Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VTK dependency for plugins correctly #809

Merged
merged 1 commit into from
May 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cmake/f3dPlugin.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,11 @@ The `NAME` argument is required. The arguments are as follows:
macro(f3d_plugin_build)
cmake_parse_arguments(F3D_PLUGIN "FREEDESKTOP;FORCE_STATIC" "NAME;DESCRIPTION;VERSION" "VTK_MODULES;ADDITIONAL_RPATHS;MIMETYPE_XML_FILES;CONFIGURATION_DIRS" ${ARGN})

if (NOT F3D_PLUGIN_VTK_MODULES)
# Make sure we are requiring at least one module
list(APPEND F3D_PLUGIN_VTK_MODULES "CommonCore")
endif ()

find_package(VTK 9.0 REQUIRED COMPONENTS ${F3D_PLUGIN_VTK_MODULES})
find_package(VTK 9.0 REQUIRED COMPONENTS
CommonCore
CommonExecutionModel
IOImport
mwestphal marked this conversation as resolved.
Show resolved Hide resolved
${F3D_PLUGIN_VTK_MODULES})

if(F3D_PLUGIN_FORCE_STATIC OR F3D_PLUGINS_STATIC_BUILD)
set(F3D_PLUGIN_TYPE "STATIC")
Expand Down