Move find_package in external/CMakeLists.txt to CMakeLists.txt #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so variables remain in scope.
|
Still have one more problem - The libsigmf install is being included in the .deb file, which we don't want. |
|
To clarify the problem: Most of the projects in external/CMakeLists.txt have the INSTALL_COMMAND set to "" and the libs and includes are picked up from the build directory rather than the install directory (which doesn't exist). However, libsigmf seems to create some needed files only during the install, so we need to run the install step for that. The deb packager is picking up those installed files, which we don't want in the .deb, so need to find a way to exclude them. Haven't used the deb packager before, so working my way though the process... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move find_package in external/CMakeLists.txt to CMakeLists.txt to see if variables remain in scope. (Needs to be tidied up if it works)
Also fix codec2 build.
Add status messages for features build.
For #1740