Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise PhaseDiscriminators state, to avoid outputting huge values. #1795

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Aug 30, 2023

This PR initialises state in the PhaseDiscriminators class, to prevent it from randomly outputting huge values (ie. 1e+30).

(When such a large value gets in to the MovingAverageUtil, it will stay there, as it keeps a running total, rather than resumming the elements. 1e30-1=1e30)

This fixes #1794.

Patch also connects scope signals in Pager demod, noticed while debugging this issue.

@f4exb f4exb merged commit f891bd6 into f4exb:master Aug 30, 2023
@srcejon srcejon deleted the fix_1794 branch September 4, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pager decoder sometimes doesn't work
2 participants