-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cleanup #2184
Fix/cleanup #2184
Conversation
The mutex will get unlocked anyway when falling out of scope.
Fixes: sdrgui/device/deviceuiset.cpp:353:36: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
Automatically deleted by opening the .ui file in Qt Creator.
Automatically updated by opening the .ui file in Qt Creator.
Automatically updated by opening the .ui file in Qt Creator.
@srcejon I am not sure plugins/feature/map/mapfmlistdialog.ui should be removed. Maybe you had in the plans to implement this and we should save the effort of making up the dialog (although git would still remember it) |
Building files from the .yaml Swagger definitions is done following these instructions: https://github.com/f4exb/sdrangel/tree/master/swagger/docker |
I was planning to import data from www.fmlist.org - but the owner of that site seems to have gone quiet, so probably wont happen. As you say, I can always dig up from git later. |
This PR:
plugins/feature/map/mapfmlistdialog.ui
doesn't seem to be used anywhere, however it would be interesting to see it implementedsdrgui/gui/rollupwidget.{cpp,h}' don't seem to be used anywhere (the class that is actually used is names
RollupContents` and its files are very similar to these deleted)unlock
and some includes related to QMutexLockerI'm not able to regenerate the
html2
docs maybe because the generate.sh script doesn't seem up to date because it is trying to edit .yaml files under sdrbase but there are none.