Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: print packages' timestamp in job 'install' #2674

Merged
merged 3 commits into from
May 23, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented May 19, 2022

Packages are uploaded to GCS through gsutil cp ${package} gs://${GCP_PATH}/${TIMESTAMP}/. Unfortunately, the target is hidden in the logs:

https://github.com/SymbiFlow/f4pga-arch-defs/runs/6472094719?check_suite_focus=true#step:4:24660

Copying file://symbiflow-arch-defs-xc7a50t-arty-swbut-overlay_test-11aa9fd.tar.xz [Content-Type=application/x-tar]...

Therefore, users cannot guess the URL of the arch-def packages generated by some specific commit. They know the format, they know the hash, but they don't know the specific timestamp. This PR prints it.

Ref chipsalliance/f4pga-examples#292

@probot-autolabeler probot-autolabeler bot added the type-infra Issues related to infra like travis. label May 19, 2022
@mithro
Copy link
Contributor

mithro commented May 19, 2022

Would be great to print the full URL too?

@mithro
Copy link
Contributor

mithro commented May 19, 2022

Maybe a candidate for the new job summary stuff - https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/?

@umarcor
Copy link
Contributor Author

umarcor commented May 19, 2022

Would be great to print the full URL too?

Since there are several URLs and all of them have a similar syntax, I don't think it's worth. The main use case is to update the date and hash used in a for loop: https://github.com/chipsalliance/f4pga-examples/pull/300/files. I.e., it's a matter of copying two values. Copying the full URL is not helpful in that case.

GitHub
Example designs showing different ways to use F4PGA toolchains. - docs/getting: use a for loop to wget arch-defs packages by umarcor · Pull Request #300 · chipsalliance/f4pga-examples

@umarcor
Copy link
Contributor Author

umarcor commented May 19, 2022

Maybe a candidate for the new job summary stuff - https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/?

That's a very interesting feature! Thanks for the reference!

However, I feel it to be out of scope of this PR. I'd like to address #2675, #2676 and #2673 before generating reports/summaries.

Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
@umarcor
Copy link
Contributor Author

umarcor commented May 20, 2022

@mithro I did some tests with GITHUB_STEP_SUMMARY in hdl/containers. There seem to be issues when using composite actions, because the summaries are overwritten. See, for instance, https://github.com/hdl/containers/actions/runs/2355254788. However, it looks quite nice if the content is written from a "regular" step. Therefore, I added printing the timestamp and the hash in the summary.

GitHub
Building and deploying container images for open source electronic design automation (EDA) - pyHDLC/run: print block titles as GHA step summary · hdl/containers@d42cbd5

Copy link
Contributor

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgugala kgugala merged commit fdbfec8 into f4pga:main May 23, 2022
@kgugala kgugala deleted the umarcor/timestamp branch May 23, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra Issues related to infra like travis.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants