Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Spartan7 50 to kokoro #1535

Closed
wants to merge 3 commits into from
Closed

Conversation

litghost
Copy link
Contributor

@litghost litghost commented Jan 8, 2021

This based on #1534, with changes need to get kokoro job running.

MaksRawski and others added 2 commits January 22, 2021 12:25
Signed-off-by: Maks Rawski <maksymilian.rawski@tutanota.com>
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@litghost litghost force-pushed the spartan7_50 branch 2 times, most recently from 6970fe9 to 8d72351 Compare January 22, 2021 20:41
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Copy link
Contributor

@dnltz dnltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings/spartan7/resources.yaml and database/spartan7/mapping/parts.yaml can be removed. database/spartan7/mapping/devices.yaml should be placed in settings/spartan7/devices.yaml.

db-extras-spartan7-parts: $(addprefix db-part-only-,$(SPARTAN_PARTS))

db-extras-spartan7-harness:
+source settings/spartan7_50.sh && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required anymore.

@mithro
Copy link
Contributor

mithro commented May 24, 2022

Closing as obsolete.

@mithro mithro closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants