-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Vite integration #495
base: main
Are you sure you want to change the base?
Conversation
@50rayn Another great contribution, thanks! The build looks good, but this dependencies should not be bundled:
To be honest, I don't remember. You can try removing it and see what happens.
I agree with you. At the beginning of the project it was convenient this way but now it's not. We can change it to a single |
Regarding both questions, I can do separate PRs. There, I'll check all the necessary changes. About those dependencies, it is fixed by ignoring the |
c247790
to
deaaffd
Compare
@50rayn Thanks! We're planning to release Unovis 1.5 soon. Will get back to this right after |
4044248
to
385d8ae
Compare
Hi @50rayn, Thanks for the contribution! There seems to be an issue with dynamic import moving from rollup to vite. I released a beta version |
Confirmed. There's a problem with imports that end with the import { Color as r } from "/Users/nikitarokotyan/unovis/node_modules/three/src/math/Color.js"; Update: Even if you remove the |
@50rayn I've tried to reconfigure the common js plugin a couple of times but without success. So now I'm out of ideas. |
385d8ae
to
9d0bc2f
Compare
Hello everyone.
|
In this PR done a couple of things:
During integration, I met some misunderstandings, like:
Why in
.npmrc
do we havelegacy-peer-deps=true
?Because of this flag, I could not install the latest version of
vite-plugin-dts
.In
@unovis/ts
in tsconfig, do we have a lot ofpaths
configured? Why?It makes more ambiguous the imports in the files. You may not understand it's imported from a file, module, and alias. I'd add just one,
"@/*": ["src/*"]
. It's more common for most users.I wanted to be sure that I could open some PRs for each of the mentions, but first of all, I need to be sure if it makes sense.