-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State-less MPI rank management #103
Changes from all commits
e69abe9
804c417
f7eb3c0
a892359
8321bfc
70e2108
026a10e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#pragma once | ||
|
||
#include <faabric/proto/faabric.pb.h> | ||
#include <faabric/transport/MessageEndpoint.h> | ||
#include <faabric/transport/common.h> | ||
#include <faabric/transport/macros.h> | ||
|
||
namespace faabric::transport { | ||
faabric::MpiHostsToRanksMessage recvMpiHostRankMsg(); | ||
|
||
void sendMpiHostRankMsg(const std::string& hostIn, | ||
const faabric::MpiHostsToRanksMessage msg); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,5 @@ | |
#define MPI_MESSAGE_PORT 8005 | ||
#define SNAPSHOT_PORT 8006 | ||
#define REPLY_PORT_OFFSET 100 | ||
|
||
#define MPI_PORT 8800 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After our offline discussion, I'll leave the port like this as it will change in coming PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the implementation of these is so simple, that they are alright with just being abstract methods. However, I thought they belonged in
transport
rather thanscheduler
.