-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to spdlog macros #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim here is to switch to using spdlog macros (
SPDLOG_DEBUG
,SPDLOG_INFO
etc.) for two reasons:How:
SPDLOG_ACTIVE_LEVEL
macro depending on whether it's a release build. This sets the minimum possible logging level (i.e. if it's set to info (2
in this case), this means the debug and trace macros are nooped).initLogging
function which callsspdlog::set_level
to set the active logging level for that execution. This selects which log statements get printed out at runtime and uses thefaabric::util::SystemConfig::logLevel
property as before.This means, in a debug build you can still change
LOG_LEVEL
todebug
ortrace
without recompiling, because we haveSPDLOG_ACTIVE_LEVEL
set to0
, thus allowing all levels of logging. However, in a release build, even if you setLOG_LEVEL
todebug
, the debug statements won't get printed as the macros are nooped.I've added the relevant comments in the code, including some warnings if you've chosen a level that won't get printed.
spdlog docs for reference.
The only files with non-trivial changes are:
include/util/logging.h
- setsSPDLOG_ACTIVE_LEVEL
, i.e. the minimum possible level.src/util/logging.cpp
- contains the implementation ofinitLogging
which sets the current logging level and log format.