Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local queue clearing #115

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Remove local queue clearing #115

merged 1 commit into from
Jun 17, 2021

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Jun 17, 2021 •
edited
Loading

As discussed offline, clearing the local queues is not necessary when destroying the world, and together with the barrier in faasm could be causing some gnarly race conditions.

@csegarragonz csegarragonz self-assigned this Jun 17, 2021
@csegarragonz csegarragonz mentioned this pull request Jun 17, 2021
Merged
Shillaker
Shillaker approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@Shillaker Shillaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to add the barrier removal here too, but equally happy with doing them separately.

@csegarragonz csegarragonz merged commit e2ccd3b into master Jun 17, 2021
@csegarragonz csegarragonz deleted the fix-mpi-world branch June 17, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shillaker Shillaker Shillaker approved these changes

Assignees

@csegarragonz csegarragonz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csegarragonz @Shillaker