Cmake cleanup Faabric Part 1 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping old versions during transition to newer toolchain
This was referenced Oct 26, 2021
Shillaker
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the faabric-base image with the newer C++20-ready toolchain, Conan and up-to-date CMake from Kitware APT repository. Also minor fixes (missing #includes) to compilation errors uncovered by using a newer libstdc++. And a tweak to workon.sh so that it actually installs the pip requirements. A faabric version bump and pointing the dockerfile to the new faabric-base will be required after this.
Replaces #162, using a branch local to the repo to allow building containers