Use matrix build for sanitisers

.github/workflows/tests.yml

@@ -12,6 +12,50 @@ defaults:
     shell: bash
 
 jobs:
+  conan-cache:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-latest
+    env:
+      HOST_TYPE: ci
+      REDIS_QUEUE_HOST: redis
+      REDIS_STATE_HOST: redis
+    container:
+      image: faasm/faabric:0.2.3
+    defaults:
+      run:
+        working-directory: /code/faabric
+    services:
+      redis:
+        image: redis
+    steps:
+      # --- Code update ---
+      - name: "Fetch ref"
+        run: git fetch origin ${GITHUB_REF}:ci-branch
+      - name: "Check out branch"
+        run: git checkout --force ci-branch
+      # --- Set-up ---
+      - name: "Ping redis"
+        run: redis-cli -h redis ping
+      # --- Cache based on Conan version and ExternalProjects cmake source
+      - name: Get Conan version
+        id: get-conan-version
+        run: |
+          echo "::set-output name=conan-version::$(conan --version | tr -d '[:alpha:] ')"
+      - name: Hash ExternalProjects
+        id: hash-external
+        run: |
+          echo "::set-output name=hash-external::$(sha256sum cmake/ExternalProjects.cmake | cut '-d ' -f 1)"
+      - uses: actions/cache@v2
+        with:
+          path: '~/.conan'
+          key: ${{ runner.os }}-${{ steps.get-conan-version.outputs.conan-version }}-${{ steps.hash-external.outputs.hash-external }}
+          restore-keys: |
+            ${{ runner.os }}-${{ steps.get-conan-version.outputs.conan-version }}-
+            ${{ runner.os }}-
+      # --- Build dependencies
+      - name: "Build dependencies to be shared by all sanitiser runs"
+        run: inv dev.cmake -b Debug
+
   formatting:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
@@ -43,11 +87,19 @@ jobs:
 
   tests:
     if: github.event.pull_request.draft == false
+    needs: [conan-cache]
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        sanitiser: [None, Address, Thread, Undefined, Leak]
     env:
       HOST_TYPE: ci
       REDIS_QUEUE_HOST: redis
       REDIS_STATE_HOST: redis
+      ASAN_OPTIONS: "verbosity=1:halt_on_error=1"
+      TSAN_OPTIONS: "verbosity=1:halt_on_error=1:suppressions=/code/faabric/thread-sanitizer-ignorelist.txt:history_size=7"
+      UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1"
     container:
       image: faasm/faabric:0.2.3
     defaults:
@@ -83,7 +135,7 @@ jobs:
             ${{ runner.os }}-
       # --- Tests build - need a debug build for actually running tests ---
       - name: "Run cmake for tests"
-        run: inv dev.cmake --build=Debug
+        run: inv dev.cmake --build=Debug --sanitiser ${{ matrix.sanitiser }}
       - name: "Build tests"
         run: inv dev.cc faabric_tests
       # --- Tests ---
@@ -93,6 +145,7 @@ jobs:
 
   dist-tests:
     if: github.event.pull_request.draft == false
+    needs: [conan-cache]
     runs-on: ubuntu-latest
     steps:
       # --- Code update ---
@@ -130,6 +183,7 @@ jobs:
 
   examples:
     if: github.event.pull_request.draft == false
+    needs: [conan-cache]
     runs-on: ubuntu-latest
     env:
       HOST_TYPE: ci

tasks/dev.py

@@ -14,7 +14,7 @@
 
 
 @task
-def cmake(ctx, clean=False, shared=False, build="Debug", sanitise_mode="None"):
+def cmake(ctx, clean=False, shared=False, build="Debug", sanitiser="None"):
     """
     Configures the build
     """
@@ -40,7 +40,7 @@ def cmake(ctx, clean=False, shared=False, build="Debug", sanitise_mode="None"):
         "-DBUILD_SHARED_LIBS={}".format("ON" if shared else "OFF"),
         "-DCMAKE_CXX_COMPILER=/usr/bin/clang++-13",
         "-DCMAKE_C_COMPILER=/usr/bin/clang-13",
-        "-DFAABRIC_USE_SANITISER={}".format(sanitise_mode),
+        "-DFAABRIC_USE_SANITISER={}".format(sanitiser),
         PROJ_ROOT,
     ]
 
@@ -92,7 +92,7 @@ def sanitise(ctx, mode, target="faabric_tests", noclean=False, shared=False):
         clean=(not noclean),
         shared=shared,
         build="Debug",
-        sanitise_mode=mode,
+        sanitiser=mode,
     )
 
     cc(ctx, target, shared=shared)