Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono vs. Stereo #40

Open
1 of 3 tasks
fab-jul opened this issue Dec 24, 2021 · 1 comment
Open
1 of 3 tasks

Mono vs. Stereo #40

fab-jul opened this issue Dec 24, 2021 · 1 comment
Assignees
@fab-jul @el-micha
Labels
low prio

Comments

@fab-jul
Copy link
Owner

fab-jul commented Dec 24, 2021 •
edited
Loading

Move towards most modules being mono:

  • all np arrays are 1 channel
  • to output multiple channels, use a multi-output module
    • introduce some output helper module: OutputHandler(left, right) that has to be added if stereo is desired

should speed up things, and simplify the code for most users / most modules.
fab-jul added a commit that referenced this issue Dec 24, 2021
@fab-jul
Remove channel dimension almost everywhere (#40).
a7eb897
@fab-jul fab-jul mentioned this issue Dec 25, 2021
Merged
el-micha added a commit that referenced this issue Dec 26, 2021
@el-micha
Merge pull request #42 from fab-jul/mono
18b6d40 
Remove channel dimension almost everywhere (#40).
@fab-jul
Copy link
Owner Author

fab-jul commented Dec 26, 2021

All np arrays are now single channel, changing priority to low. We can handle multi-outptus if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fab-jul fab-jul

@el-micha el-micha

Labels
low prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fab-jul @el-micha