Skip to content

Commit

Permalink
setTextIsSelectable onAttachedToWindow
Browse files Browse the repository at this point in the history
Code Review from ShikaSD facebook#28952 (comment)
A similar solution was merged to master for a similar problem with TextInput inside FlatList facebook#28852
  • Loading branch information
fabOnReact committed Aug 4, 2021
1 parent b01c4d5 commit d6f204d
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import static com.facebook.react.views.text.TextAttributeProps.UNSET;

import android.content.Context;
import android.graphics.Canvas;
import android.graphics.drawable.Drawable;
import android.os.Build;
import android.text.Layout;
Expand Down Expand Up @@ -437,12 +436,12 @@ public void onStartTemporaryDetach() {

public void setSelectableText(boolean value) {
mSelectableText = value;
invalidate();
}

@Override
public void onAttachedToWindow() {
super.onAttachedToWindow();
setTextIsSelectable(mSelectableText);
if (mContainsImages && getText() instanceof Spanned) {
Spanned text = (Spanned) getText();
TextInlineImageSpan[] spans = text.getSpans(0, text.length(), TextInlineImageSpan.class);
Expand All @@ -464,12 +463,6 @@ public void onFinishTemporaryDetach() {
}
}

@Override
public void onDraw(Canvas canvas) {
super.onDraw(canvas);
setTextIsSelectable(mSelectableText);
}

@Override
public boolean hasOverlappingRendering() {
return false;
Expand Down

0 comments on commit d6f204d

Please sign in to comment.