Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborators & Event section #10

Merged
merged 20 commits into from
May 9, 2019
Merged

Add collaborators & Event section #10

merged 20 commits into from
May 9, 2019

Conversation

tuengominh
Copy link
Contributor

@tuengominh tuengominh commented Jan 11, 2019

Hi Kate, I added the collaborators, pls refer to this link: https://tuengominh.github.io/newfabcity/. There is one collaborator missing (Maker) since I could not find their website. You can give me their website on Slack and I will add them to our collaborators :) I also input information for current properties (org, orgtype, strategic focus, joined year...).

@tuengominh tuengominh changed the title Add collaborators Add collaborators & Event section Mar 28, 2019
@tuengominh
Copy link
Contributor Author

tuengominh commented Apr 2, 2019

Hi Kate, you can check this link for all 3 issues: https://tuengominh.github.io/newfabcity/ and if it's ok, you can merge this pull request :)

After merged, you can refer to the File section on CloudCannon to create more events.

Lemme know if you need anything else.

Thanks

@Katearmstrong4
Copy link
Contributor

Hey @tuengominh - I'm back in the office this week.
Page is looking super.
Just a few additional qu:

Can we pls make the events a max of 3 across the page?
There was a video in the header. Has the link been broken?
Screen Shot 2019-04-30 at 10 49 34
Can we add a white box behind this section so that it stands out more? Or a black box with white writing?

I will also ask Manu (graphic designer from Fab Lab ) to go over it with you to make sure the spacing etc are correct. When would you have a chance to do it?

Thanks!
Kate

@tuengominh
Copy link
Contributor Author

Hi Kate,

Sorry for my late reply.

1/ There was a video in the header. Has the link been broken?
=> no don't worry. it works locally in my machine (as below pic) and it will work when we deploy the page (by merging it). the demo page (*.github.io cannot play the video but it's there :) )
Screen Shot 2019-05-03 at 4 52 47 PM

2/ Can we pls make the events a max of 3 across the page?
3/ Can we add a white box behind this section so that it stands out more? Or a black box with white writing?
4/ I will also ask Manu (graphic designer from Fab Lab ) to go over it with you to make sure the spacing etc are correct. When would you have a chance to do it?

=> yes to all. I think lemme talk with the designer and I will revise them all. I'll be at the office next week, whenever Manu is available.

Thanks

@Katearmstrong4 Katearmstrong4 merged commit a0ee166 into fabcity:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants