undefined and unkown are marked as optional

[emilgpa]

For example, with the follow schema:

export const mySchema = object({
    value: unknown(),
    checked: boolean(),
})

valibot returns as:

const mySchema: ObjectSchema<{
    value: UnknownSchema<unknown>;
    checked: BooleanSchema<boolean>;
}, undefined, {
    checked: boolean;
    value?: unknown;
}>

and

type H = Output<typeof mySchema>

is equal to

type H = {
    checked: boolean;
    value?: unknown;
}

but it should be:

type H = {
    checked: boolean;
    value: unknown;
}

[fabian-hiller]

Thanks a lot for creating this issue. I will fix that as soon as possible.

[fabian-hiller]

I have now investigated the problem. Zod behaves the same way as Valibot, and theoretically it is not completely wrong, since any and unknown also include undefined. However, it would be better if entries were only marked as optional with a question mark when using optional because there is of course an difference between an undefined and optional entry. I will investigate this further.

[fabian-hiller]

Should I mark a field as optional only if optional is used or also with nullish?

[emilgpa]

In my opinion, it should be only if optional is used. The other one, nullish, I would leave only to mark the field as null or undefined

[fabian-hiller]

This issue will be solved in the next minor version of Valibot.

[fabian-hiller]

v0.23.0 is now available.