Skip to content

Commit

Permalink
release Woof! 12.0.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@fabiangreffrath
fabiangreffrath committed Dec 13, 2023
1 parent d9b2197 commit f75ebb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ set(X_VCPKG_APPLOCAL_DEPS_INSTALL ON)
cmake_minimum_required(VERSION 3.9)

project("Woof"
VERSION 12.0.1
VERSION 12.0.2
LANGUAGES C)

set(CMAKE_C_STANDARD 99)
Expand Down

9 comments on commit f75ebb2

@fabiangreffrath
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfomin @ceski-1
How do you like the idea to adopt LibreOffice's versioning schema. That is YEAR.MONTH.RELEASE, so the next release would be e.g. 24.2.0?

@rfomin
Copy link
Collaborator

@rfomin rfomin commented on f75ebb2 Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you like the idea to adopt LibreOffice's versioning schema. That is YEAR.MONTH.RELEASE, so the next release would be e.g. 24.2.0?

I don't like it. Although what will be the next version number? A lot of changes have been made. How about 1.0.0? 😄

@JNechaevsky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99 + 1 = 00, integer overflow! ☝️

@fabiangreffrath
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 1.0.0? 😄

Again? We are already at 12. 😉

@ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented on f75ebb2 Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you like the idea to adopt LibreOffice's versioning schema. That is YEAR.MONTH.RELEASE, so the next release would be e.g. 24.2.0?

I vote to keep major.minor.patch.

Somewhat related though, I suggest using the commit hash in the title of autobuilds. Maybe even when someone builds from source. The version number should only be for official releases.

@ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented on f75ebb2 Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By title I mean the title bar of the window or what's printed in the console. The build time/date is often included as well.

@rfomin
Copy link
Collaborator

@rfomin rfomin commented on f75ebb2 Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related though, I suggest using the commit hash in the title of autobuilds. Maybe even when someone builds from source. The version number should only be for official releases.

It is surprisingly complicated. We can use this: https://github.com/andrew-hardin/cmake-git-version-tracking

@ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented on f75ebb2 Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is surprisingly complicated. We can use this: https://github.com/andrew-hardin/cmake-git-version-tracking

Yes, that seems like what we want. I'm not really knowledgeable about build systems so I'll have to go with your judgment to decide whether it's a good idea or too code heavy.

@rfomin
Copy link
Collaborator

@rfomin rfomin commented on f75ebb2 Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is surprisingly complicated. We can use this: https://github.com/andrew-hardin/cmake-git-version-tracking

Yes, that seems like what we want. I'm not really knowledgeable about build systems so I'll have to go with your judgment to decide whether it's a good idea or too code heavy.

It's not worth it at the moment. Not many people build Woof or use artifacts. I like that our build system is relatively simple and I understand all parts of it.

Please sign in to comment.