rewrite D_DoomExeDir() to use SDL_GetBasePath()

[fabiangreffrath]

No description provided.

[fabiangreffrath]

Hm, I'll either have to include d_main.c in SETUP_SOURCES, or move the function to a different source file. Any suggestions?

[fabiangreffrath]

The rationale for this is that SDL has quite some sophisticated means for determining the directory from which the process executable was started for different OSes, and they do not even fall back to parsing argv[0] (but we do):

https://github.com/libsdl-org/SDL/blob/e8b6edd5a081d0b45c2ac39ab690e584a6b95a84/src/filesystem/unix/SDL_sysfilesystem.c#L248

[rfomin]

Hm, I'll either have to include d_main.c in SETUP_SOURCES, or move the function to a different source file. Any suggestions?

We can move D_DoomExeDir() to i_system.c or d_iwad.c. By the way, there is no SDL_GetBasePath() in Chocolate Doom, so maybe we don't need these complexities 😉

[fabiangreffrath]

We can move D_DoomExeDir() to i_system.c or d_iwad.c.

d_iwad.c feels like the more natural choice.

By the way, there is no SDL_GetBasePath() in Chocolate Doom, so maybe we don't need these complexities 😉

Yes, but Chocolate Doom's development more or less ceased right after the 3.0.0 release, which marked the initial switch to SDL 2. 😉