Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bunny scroll for 32:9 aspect ratio #1783

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Jul 12, 2024

Fix #1782

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the implementation that @mikeday0 once added to Crispy Doom, right?

@rfomin
Copy link
Collaborator Author

rfomin commented Jul 12, 2024

This is the implementation that @mikeday0 once added to Crispy Doom, right?

This is an adaptation of PrBoom+'s: https://github.com/coelckers/prboom-plus/blob/969515162c5aebea4ad7a125ee178dcad3d576ad/prboom2/src/f_finale.c#L666-L680

I don't think that Bunnytest.zip is correct, but it works in PrBoom+/DSDA (and in Crispy).

@rfomin rfomin merged commit df6c088 into fabiangreffrath:master Jul 12, 2024
8 checks passed
@rfomin rfomin deleted the fix_bunny branch July 12, 2024 10:51
@Meerschweinmann
Copy link

Meerschweinmann commented Jul 12, 2024

I don't think that Bunnytest.zip is correct,

Hello :)

May i ask how it is done technically correct? I was not sure how to do it and oriented me on Nash Muhandes Widepix. Because it worked in Crispy and Inter, i thought that is the good way.

And thank you for the fix.

@rfomin
Copy link
Collaborator Author

rfomin commented Jul 12, 2024

May i ask how it is done technically correct?

I think PFUB1 and PFUB2 should have the same width. Take a look at Bethesda's wide assets. At least your test WAD doesn't work properly in the Eternity Engine.

@mikeday0
Copy link
Contributor

This is the implementation that @mikeday0 once added to Crispy Doom, right?

Not me. :) I think it was @SmileTheory.

@Meerschweinmann
Copy link

May i ask how it is done technically correct?

I think PFUB1 and PFUB2 should have the same width. Take a look at Bethesda's wide assets. At least your test WAD doesn't work properly in the Eternity Engine.

Thanks for that hint Roman.

Ah, Bethesda has two equal wide pictures which overlap in the middle.
In the end it is full horizontal widescreen Resolution (In Bethesdas case 560, because 21:9) plus 320 pixels as seen with PFUB0 Bethesda has in its WAD. And then cut PFUB1 and PFUB2 out of this picture.

I will change it that way and will have a look at EE too.

@Meerschweinmann
Copy link

Meerschweinmann commented Jul 12, 2024

Have changed the PFUB pictures overlapped like they are in the Bethesda widescreen release and they work fine with the new Woof dev-build.
I have tested the new pictures with EE too and they work there too after this change.

Thanks again for this hint @rfomin

Here is the new 32:9 Bunnytest:

Bunnytest_V2.zip

I have added a WIMAP2, that you can see the 1 pixel shift of the animated parts from the episode 3 intermission in 32:9 mode.
In 21:9 or 16:9 it is fine for example.
Or should i open a new issue about this?

@rfomin
Copy link
Collaborator Author

rfomin commented Jul 12, 2024

I have added a WIMAP2, that you can see the 1 pixel shift of the animated parts from the episode 3 intermission in 32:9 mode.

Thanks, I will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming 32:9 support. With 32:9 widescreen assets bunny scroller has a problem.
4 participants