Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shifted keys when typing savegame names #1792

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix shifted keys when typing savegame names #1792

wants to merge 1 commit into from

Conversation

fabiangreffrath
Copy link
Owner

Fixes #1773

@fabiangreffrath
Copy link
Owner Author

There is probably a more elegant solution. I'm considering to factor that shiftxform[] stuff into something like M_ToShifted().

@rfomin
Copy link
Collaborator

rfomin commented Jul 14, 2024

There is probably a more elegant solution. I'm considering to factor that shiftxform[] stuff into something like M_ToShifted().

Maybe we should adapt system from Chocolate Doom (TranslateKey, GetLocalizedKey, GetTypedChar): https://github.com/chocolate-doom/chocolate-doom/blob/2ea764fed6a266e291cf37375f52bc92260f686c/src/i_input.c#L254-L256

It seems that #1772 is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shift doesn't work when typing savegame names
2 participants
@fabiangreffrath @rfomin