Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto save feature #1939

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Add auto save feature #1939

merged 7 commits into from
Oct 4, 2024

Conversation

ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented Oct 2, 2024

details

Simple behavior:

  • Auto save at the beginning of a map, after completing the previous one
  • Menu item under General > Misc
  • Off by default
  • Disabled for demos and multiplayer

Example of completing a map, the next one loads, then the game auto saves (note the game saved. in the upper left corner):

save_autosave.mp4

Notice that the save description is the default one with (Auto) appended.

If On Death Action is set to Last Save, the auto save will be loaded if it's more recent than the regular save in the player's current save slot. That's usually the case when the player forgets to save on the current level, and that's where this feature is most helpful. Example:

death_use_load_autosave.mp4

The first save slot on the first save page is reserved for auto saving. The auto save is kept separate from woofsav0.dsg in a dedicated file named autosave.dsg. Toggling the "Auto Save" menu item toggles which one is shown.

preserve_existing_saves.mp4

The auto save slot is enabled when using the regular load menu, but disabled for the regular save menu. This is so the player doesn't try to save to that slot only for the save to be replaced by the auto save later.

Quick saving and quick loading can't select the auto save slot either, so that those keys can continue to function independently.

src/mn_menu.c Outdated Show resolved Hide resolved
@rfomin
Copy link
Collaborator

rfomin commented Oct 3, 2024

Great work, thank you!

The first save slot on the first save page is reserved for auto saving. The auto save is kept separate from woofsav0.dsg in a dedicated file named autosave.dsg. Toggling the "Auto Save" menu item toggles which one is shown.

I don't like that autosave hides the first normal save (woofsav0.dsg) in the menu. Is it possible to increase the number of save slots in the menu if autosave is enabled?

@ceski-1
Copy link
Collaborator Author

ceski-1 commented Oct 3, 2024

I don't like that autosave hides the first normal save (woofsav0.dsg) in the menu. Is it possible to increase the number of save slots in the menu if autosave is enabled?

Okay, added a separate auto save slot that appears in the load game menu only (like other fps games):

separate_auto_save_slot.mp4

Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works great!

I really like this feature, how about enabling it by default?

@ceski-1
Copy link
Collaborator Author

ceski-1 commented Oct 4, 2024

how about enabling it by default?

Okay, enabled by default.

@ceski-1 ceski-1 merged commit 9a43e54 into fabiangreffrath:master Oct 4, 2024
8 checks passed
@ceski-1 ceski-1 deleted the autosave branch October 4, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants