add "refraction" fuzz mode #2043

rfomin · 2024-11-22T11:50:36Z

Fix #2040

Translucent option looks bad:

fabiangreffrath · 2024-11-22T11:55:30Z

Translucent option looks bad:

How did you create the fuzztran table?

fabiangreffrath · 2024-11-22T12:04:01Z

Stupid question probably, but will this also affect the partly invisible weapon sprite rendering?

rfomin · 2024-11-22T12:29:51Z

How did you create the fuzztran table?

It's just a normal tranmap at 33% (-dumptranmap command). We should recreate it for a different palette, but I don't like the result anyway.

Stupid question probably, but will this also affect the partly invisible weapon sprite rendering?

Yes.

fabiangreffrath · 2024-11-22T13:04:55Z

It's just a normal tranmap at 33% (-dumptranmap command). We should recreate it for a different palette, but I don't like the result anyway.

Will it look better with 50% translucency? Or how about our usual 66%?

We once got a request to entirely drop the percent selection for the tranmap, and I actually think that this would be the right thing to do anyway.

rfomin · 2024-11-22T13:21:56Z

Will it look better with 50% translucency? Or how about our usual 66%?

50%

Maybe we should also do something with colormap. Or just remove the "translucent fuzz" option.

We once got a request to entirely drop the percent selection for the tranmap, and I actually think that this would be the right thing to do anyway.

I think we should remove it from the menus, but still keep it in the config. It seems there are users for every little option 😄

rfomin · 2024-11-22T13:48:04Z

#define FUZZDARK 12 * 256 instead of 6 * 256:

Mybe it's a better idea than translucency.

fabiangreffrath · 2024-11-22T13:48:36Z

50%

Looks better already, but I wouldn't want to introduce (and regenerate on playpal changes) just another tranmap for this obscure feature.

Maybe we should also do something with colormap. Or just remove the "translucent fuzz" option.

I'd say we should go with the color/translucency translation tables that we already have or omit this feature entirely. I don't care that much if we do the gray transition before applying translucency or not. I just thought it would be nice to have spectres appear like actual ghosts. 😉

I think we should remove it from the menus, but still keep it in the config. It seems there are users for every little option 😄

Sure, we have to keep this config-only. I even think this is one of the few config options that are allowed to be changed by an OPTIONS lump.

fabiangreffrath · 2024-11-22T13:50:03Z

Mybe it's a better idea than translucency.

Oh, this will improve the "selective" option quite a lot.

rfomin · 2024-11-22T13:55:42Z

Mybe it's a better idea than translucency.

Oh, this will improve the "selective" option quite a lot.

I like the original "selective" variant too, it feels like it was what was intended and the vanilla "fuzz" implemenatation was a mistake. But how to name these options? "Selective" and "Selective Alt"?

src/r_draw.c

ceski-1 · 2024-11-22T14:11:00Z

src/r_draw.h

-extern boolean fuzzcolumn_mode;
+typedef enum
+{
+    FUZZ_ORIGINAL,


Should we just drop the res-dependent option?

Why? It doesn't cost anything and other ports with increased resolution still look like this.

Fewer options, the better. Especially bad ones.

other ports with increased resolution still look like this

I never like it.

If there is any performance benefit, it can be used internally at 1x scale still, but I don't see any reason to expose it as a menu option these days.

Removed in a14a89b

ceski-1 · 2024-11-22T14:16:05Z

src/mn_setup.c

@@ -2115,6 +2120,9 @@ static setup_menu_t enem_settings1[] = {
    {"Translucent Ghost Monsters", S_ONOFF | S_STRICT | S_VANILLA, M_X, M_SPC,
     {"ghost_monsters"}},

+    {"Spectre Drawing", S_CHOICE | S_STRICT, M_X, M_SPC, {"fuzzcolumn_mode"},


This applies to the effect in general (i.e. weapon too), so maybe we should use this opportunity to name this better.

I think the manual uses the term "partial translucency".

Also, it should probably be moved to General > Display.

ceski-1 · 2024-11-22T14:20:46Z

I combined translucency (not grayscale) and selective (wavy effect) as an experiment for Crispy Strife a long time ago and thought it looked great. Just an idea.

Also, do any of these changes actually address the original issue?

fabiangreffrath · 2024-11-22T14:22:54Z

But how to name these options? "Selective" and "Selective Alt"?

Welcome to the can of worms of trying to implement everybody's favorite solution. 😉

ceski-1 · 2024-11-22T14:24:34Z

Right, the downside to adding this is everyone asking for their own personal variation.

rfomin · 2024-11-22T14:34:41Z

Also, do any of these changes actually address the original issue?

Darker variants of "selective" address it, I think. But we need better names for these options.

rfomin · 2024-11-22T15:05:53Z

src/mn_setup.c

@@ -3239,6 +3240,10 @@ static const char *exit_sequence_strings[] = {
    "Off", "Sound Only", "PWAD ENDOOM", "Full"
 };

+static const char *fuzzmode_strings[] = {
+    "Blocky", "Selective", "Selective Dark"


Temporary names. Any suggestions?

Not sure if we actually need "selective" at all. It's really hard to see, even worse than "original". How about "original" and "alternative" instead of "selective dark"?

I've made it slightly darker there: 11a95d9

I didn't get a good result with translucency + “selective”, maybe @ceski-1 can help.

There is still a nomenclature mixture of "selective" and "refraction".

There is still a nomenclature mixture of "selective" and "refraction".

Fixed in 2e7f028

fabiangreffrath · 2024-11-26T11:43:54Z

I think "refraction" is still a bit harder to see (i. e. "lighter") than "vanilla" and thus won't help the original intent of this change to fix #2040.

Vanilla:

Refraction:

rfomin · 2024-11-26T11:49:02Z

I think "refraction" is still a bit harder to see (i. e. "lighter") than "vanilla" and thus won't help the original intent of this change to fix #2040.

I agree, it's just an alternative mode. Translucent looks bad, I don't think it's worth it.

fabiangreffrath · 2024-11-26T11:52:38Z

I think I liked this better:

#define FUZZDARKER 12 * 256

fabiangreffrath · 2024-11-26T11:54:41Z

Or let's say 10 * 256 as a compromise? 😁

rfomin · 2024-11-26T12:08:15Z

Or let's say 10 * 256 as a compromise? 😁

I don't know, for me it's too dark and loses the “predator” look that I think was originally intended for this effect. We could add another mode.

fabiangreffrath · 2024-11-26T12:53:26Z

Alright, fine with me. But then we will really need a third mode, because this won't fix #2040 as it is now.

rfomin · 2024-11-26T13:00:10Z

I know spectres are meant to be hard to see I'm not trying to suggest anything like this:

Instead maybe something like this:

I don't want the spectre's position to be clear as day, I just want to have an option to get rid of that damn pixel pattern

Well, I think "dark refraction" is the solution.

rfomin · 2024-11-26T13:55:45Z

Added a simple "Shadow" mode:

fabiangreffrath · 2024-11-26T14:15:54Z

Okay, why not!

fabiangreffrath · 2024-11-26T14:16:36Z

What does @a1-21 say? What does @ceski-1 say?

add selective and translucent fuzz modes

f5cf7f4

ceski-1 reviewed Nov 22, 2024

View reviewed changes

src/r_draw.c Show resolved Hide resolved

ceski-1 reviewed Nov 22, 2024

View reviewed changes

add "Selective Dark" variant, remove "Original" option

a14a89b

rfomin commented Nov 22, 2024

View reviewed changes

rfomin added 4 commits November 26, 2024 16:20

Merge branch 'master' into fuzz_options

4cf61c5

remove "Selective Dark", use Ceski's naming

9689aa1

make exception for first line/block of pixels in column

445044a

make "Refraction" mode darker

11a95d9

rfomin force-pushed the fuzz_options branch from caa93a1 to 11a95d9 Compare November 26, 2024 11:06

rename selective->refraction

2e7f028

rfomin changed the title ~~add selective and translucent fuzz modes~~ add "refraction" fuzz mode Nov 26, 2024

add simple "Shadow" mode

028234a

add "refraction" fuzz mode #2043

Are you sure you want to change the base?

add "refraction" fuzz mode #2043

Conversation

rfomin commented Nov 22, 2024

fabiangreffrath commented Nov 22, 2024

fabiangreffrath commented Nov 22, 2024

rfomin commented Nov 22, 2024 • edited Loading

fabiangreffrath commented Nov 22, 2024

rfomin commented Nov 22, 2024 • edited Loading

rfomin commented Nov 22, 2024

fabiangreffrath commented Nov 22, 2024

fabiangreffrath commented Nov 22, 2024

rfomin commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ceski-1 commented Nov 22, 2024 • edited Loading

fabiangreffrath commented Nov 22, 2024

ceski-1 commented Nov 22, 2024 • edited Loading

rfomin commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabiangreffrath commented Nov 26, 2024

rfomin commented Nov 26, 2024

fabiangreffrath commented Nov 26, 2024

fabiangreffrath commented Nov 26, 2024

rfomin commented Nov 26, 2024

fabiangreffrath commented Nov 26, 2024

rfomin commented Nov 26, 2024

rfomin commented Nov 26, 2024

fabiangreffrath commented Nov 26, 2024

fabiangreffrath commented Nov 26, 2024

rfomin commented Nov 22, 2024 •

edited

Loading

rfomin commented Nov 22, 2024 •

edited

Loading

ceski-1 commented Nov 22, 2024 •

edited

Loading

ceski-1 commented Nov 22, 2024 •

edited

Loading