rename sbw_secret->sbw_announce, announce level in central message #2064
Conversation
Don't colorize secret message.
Should level name announce also be gold? |
|
I'd say they shouldn't be in the center of the screen in the first place. |
I played some WADs with it and I like it. I think it's a good idea. |
Done in 0930831 |
|
Thanks! |
| @@ -142,12 +144,19 @@ static void UpdateSecretMessage(sbe_widget_t *widget, player_t *player) | |||
| return; | |||
| } | |||
|
|
|||
| static char string[80]; | |||
There was a problem hiding this comment.
The level title won't be displayed if hud_secret_message == 0.
There was a problem hiding this comment.
Thanks!
As it is now, the "secret revealed" message immediately overrides the map announcement if the player starts the map in a sector tagged as secret. Is this intended? Could we show both messages on two lines probably?
There was a problem hiding this comment.
As it is now, the "secret revealed" message immediately overrides the map announcement if the player starts the map in a sector tagged as secret. Is this intended?
Yes, it's intended. For me, the secret message is more important than the level title, but we can change the priority if you prefer. By the way, what is this map?
Could we show both messages on two lines probably?
It won't look good.
There was a problem hiding this comment.
By the way, what is this map?
A copy of MAP01 with the starting sector tagged as secret. 😁
I have seen a map like this in the wild, but couldn't remember which it was.
There was a problem hiding this comment.
BTW, why do we clear the line and add the string again during each tic for this widget? The strings aren't going to change anyway.
There was a problem hiding this comment.
Strings can change, e.g. if the player enters a secret sector while the map announce is still on. Note that no strings are copied every tic, only pointers.
I check if lines array is not empty in widget drawing function.
We can check if (string[0] == '/0'), but this code is more complicated and there is no performance benefit - no strings are copied anyway.
Don't colorize secret message.
Fix #2039 Also fix [doomworld]