Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify on pause and resume #32

Closed
MarcusWolschon opened this issue Jul 11, 2016 · 7 comments
Closed

notify on pause and resume #32

MarcusWolschon opened this issue Jul 11, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@MarcusWolschon
Copy link
Contributor

The plugin should also allow the user to get a notification on pause and on resume.

@MiguelAngelLV
Copy link

Will it notifiy when I need change the filament?

@MarcusWolschon
Copy link
Contributor Author

When you need to change filament, https://github.com/MarcusWolschon/UltimateFilamentSensor/ could pause the print and this plugin would then inform you about the pause.

Octoprint-Telegram has no knowledge about how much filament you have left and that's not the job of this plugin.

@MiguelAngelLV
Copy link

I wanted to say when I used m600 code to change filament (for change color
filament). The printer pause the printing and wait.

I will want that, when the printer pause, it send my a message

El lun., 18 jul. 2016 a las 23:15, Marcus Wolschon (<
notifications@github.com>) escribió:

When you need to change filament,
https://github.com/MarcusWolschon/UltimateFilamentSensor/ could pause the
print and this plugin would then inform you about the pause.

Octoprint-Telegram has no knowledge about how much filament you have left
and that's not the job of this plugin.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#32 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAm8nia2Eo_WWpLwFRDskgAqkREBpADTks5qW-z_gaJpZM4JJrVS
.

@MarcusWolschon
Copy link
Contributor Author

MarcusWolschon commented Jul 20, 2016

Ok, my patch does a Telegram-notification when Octoprint does a pause.

M600 sounds like a g-code command that makes the printer wait for you to change filament.
As far as Octoprint is concerned, that wait is part of printing as afterwards more commands will be sent.

This sounds like a different issue and has nothing to do with the Telegram-Plugin or this specific feature-requres for the Telegram-Plugin.

@derpicknicker1
Copy link
Collaborator

Hey. I was quite busy the last months. Started a new job...so i had no time to work on the plugin.
Thank you @MarcusWolschon for your pull request. I'm not sure if i will integrate it. My plan is to let the user define own notification hooks on every event octoprint throws. But it will take a bit of time to integrate this. Especially the settings system (care of the the rights of users) will take some work. I think this dynamic way of adding notifications will be a better way than to hardcode more notifications.
This topic is one of the most top items on my list. So stay tuned :)

@derpicknicker1 derpicknicker1 added this to the 2.0 milestone Sep 24, 2016
@derpicknicker1 derpicknicker1 self-assigned this Sep 24, 2016
@derpicknicker1 derpicknicker1 modified the milestone: 1.4.0 Sep 24, 2016
@derpicknicker1
Copy link
Collaborator

Done in 1.4.0 (will come soon).

@AdmiralHawkins
Copy link

Hi, derpicknicker1, I installed your plugin, it sends me notification when print starts and when it ends but not when a m600 command occurs, even if I enabled notifications for pause event. Do I have to configure/enable something in particular to catch m600 command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants