Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send webcam captured imaged even if the printer is not connected #34

Open
svh1985 opened this issue Jul 11, 2016 · 6 comments
Open

Send webcam captured imaged even if the printer is not connected #34

svh1985 opened this issue Jul 11, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@svh1985
Copy link

svh1985 commented Jul 11, 2016

I would love too also receive a picture if I send the /status command, even if the printer is disconnected.
Usually, at least in my case, the webcam remains connected to the Octoprint server and pointed to the 3D printer even if the printer is offline.

Thanks!

MarcusWolschon added a commit to MarcusWolschon/OctoPrint-Telegram that referenced this issue Jul 18, 2016
@MarcusWolschon
Copy link
Contributor

I can't figure it out. Sombody else should implement this.

@derpicknicker1 derpicknicker1 added this to the 2.0 milestone Sep 24, 2016
@derpicknicker1 derpicknicker1 self-assigned this Sep 24, 2016
@derpicknicker1 derpicknicker1 modified the milestone: 1.4.0 Sep 24, 2016
@derpicknicker1
Copy link
Collaborator

Done in 1.4.0

@DaAwesomeP
Copy link

I'm having issues with this. If the printer is not connected and I send /status, I just get (without an image):

⚠️ Not connected to a printer. Use /con to connect.

@DaAwesomeP
Copy link

I see there's a related TODO here on line 77:

def cmdStatus(self,chat_id,**kwargs):
#if not self.main._printer.is_operational():
# TODO: self.main._settings.get(['messages',str(kwargs['event']),'image'])
# TODO: implement "Send webcam captured imaged even if the printer is not connected" #34
#kwargs['with_image'] = True
#self.main.send_msg(self.main.gEmo('warning') + " Not connected to a printer. Use \connection to connect."),chatID=chat_id,**kwargs)
#elif self.main._printer.is_printing():
self.main.on_event("StatusPrinting", {},chatID=chat_id)
#else:
#self.main.on_event("StatusNotPrinting", {},chatID=chat_id)

@DaAwesomeP
Copy link

Is it possibly because there is not an 'image': True setting here?

'StatusPrinting': {
'bind_msg': 'ZChange',
'no_setting': True
}

I would love to submit a pull if this is a fix!

@derpicknicker1
Copy link
Collaborator

I will review this

@derpicknicker1 derpicknicker1 reopened this Jan 8, 2018
@derpicknicker1 derpicknicker1 modified the milestones: 1.4.0, 1.4.3 Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants