Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tslint as a dev dependency #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds tslint as a dev dependency #41

wants to merge 2 commits into from

Conversation

vitkon
Copy link

@vitkon vitkon commented Dec 10, 2017

If TSLint is not installed globally, it will not lint in IDE
local tslint installation fixes it

@fabien0102
Copy link
Owner

Deploy preview ready!

Built with commit 5a99ddb

https://deploy-preview-41--fabien0102-gatsby-starter.netlify.com

@fabien0102
Copy link
Owner

It's strange, we have already a ts-lint dependency and you add tslint (I need to check the difference between the both), and AppVeyor should not like this tslint 😞

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "lint"
npm ERR! node v6.12.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! gatsby-starter@1.0.0 lint: `npm run lint:ts && npm run lint:md && npm run lint:js && npm run lint:css`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the gatsby-starter@1.0.0 lint script 'npm run lint:ts && npm run lint:md && npm run lint:js && npm run lint:css'.

@vitkon
Copy link
Author

vitkon commented Dec 11, 2017

didn't realise there are 2 modules: tslint and ts-lint.
It's just my VS Code linting only started to work when I added tslint

So you know what's the difference between these modules?

@fabien0102
Copy link
Owner

@vitkon mmm, so maybe try to totally replace ts-lint by tslint.
I want to have the actual lint-staged hook working and the npm run ts:lint also working 😉

@garthk
Copy link

garthk commented Jan 21, 2018

@fabien0102 ts-lint is a typosquat version of tslint, stuck back at version 4.5.1 (cf 5.9.1). Not sure if it's safe or not. I'd switch.

Update: I've confirmed ts-lint is a clean build of palantir/tslint@ee721bb, but I'd still switch to tslint for updates and peace of mind.

@fabien0102
Copy link
Owner

@garthk Perfect, so you can remove and replace totally ts-lint by tslint in this PR and I approve this 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants