DO NOT MERGE!!! This PR is meant to test what in package-lock.json breaks netlify #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By luck found that. It refers to same problems. That has to do something with webpack config, so ned to dig into gatsby again. https://stackoverflow.com/questions/49193838/webpack-ts-loader-throws-error-that-property-makehot-is-missing-on-type-nodemo |
sielay
force-pushed
the
breaking-netlify
branch
from
60d8d5f
to
b17cfb7
Compare
sielay
commented
Mar 25, 2018
| @@ -7,7 +7,7 @@ | |||
| "scripts": { | |||
| "start": "gatsby develop", | |||
| "develop": "gatsby develop", | |||
| "build": "gatsby build", | |||
| "build": "npm run patch && gatsby build", | |||
There was a problem hiding this comment.
sielay
commented
Mar 25, 2018
| @@ -40,11 +41,11 @@ | |||
| "gatsby-plugin-google-analytics": "latest", | |||
| "gatsby-plugin-manifest": "latest", | |||
| "gatsby-plugin-offline": "latest", | |||
| "gatsby-plugin-sharp": "latest", | |||
| "gatsby-plugin-sharp": "^1.6.31", | |||
There was a problem hiding this comment.
sielay
commented
Mar 25, 2018
|
|
||
| return ( | ||
| return ( | ||
| <Provider store={store}> |
sielay
commented
Mar 25, 2018
| render() { | ||
| const { pathname } = this.props.location; | ||
| const isHome = pathname === "/"; | ||
| export default (props: DefaultLayoutProps): JSX.Element => { |
There was a problem hiding this comment.
Some changes around typings make that TS is picky about class form components here.
|
@sielay I close this PR, normally it's resolve 😄 |
|
Is it? Ok. Let's do it. I think we still have a problem when upgrading packages. Will take a look. |
|
If you have any needs, you can of course reopen this PR 😉 It's just to cleanup a little bit my "todo list" ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.