Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test lib's #105

Merged
merged 16 commits into from
May 30, 2024
Merged

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented May 26, 2024

I just wanted to update the Jackson lib, but then i ended up checking the whole list ;)

After some fighting with (non-semver) breaking changes in avaje-jsonb and json-io i was able to execute both ./run ser and .run/deser successfully.

Some notable points:

  • dsl-json had a new major release (v2.x). I followed the migration section in the project readme, looking at this no further modifications are necessary, but you never know... so i added this commit at the very end in case we want to drop it again
  • same with apache johnzon. there does not seem to be much information available on any migration process… so just putting this here, to be dropped easily again in case execution fails with it
  • json-io had a typo in the version no. in the README.md which was introduced via a manual revert here. Probably it was reverted b/c i found out the hard way there was a breaking change in the API and the migration instructions are barely existent. However, works now with the new API – if not, simply git revert 91d279b before merging (i may also simply rebase and drop the commit if desired)
  • I had a little confusion about senthilganeshs/jsonp vs. https://github.com/tonivade/purejson. The former hasn't seen any activity in the last five years, while the latter seems pretty active, but is not yet included in the shootout – maybe a good one to add?

@Philzen Philzen changed the title Update jackson lib Update test lib's May 26, 2024
@Philzen
Copy link
Contributor Author

Philzen commented May 26, 2024

After following the discussion in #104, i dropped the fastjson update 2cbcf08 in this PR now

Copy link
Owner

@fabienrenaud fabienrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Left a couple of trivial comments.

README.md Outdated Show resolved Hide resolved
@fabienrenaud
Copy link
Owner

I had a little confusion about senthilganeshs/jsonp vs. https://github.com/tonivade/purejson. The former hasn't seen any activity in the last five years, while the latter seems pretty active, but is not yet included in the shootout – maybe a good one to add?

Indeed. I can't find the source for senthilganeshs/jsonp anymore... Let's remove it in a separate PR. If tonivade/purejson uses the same API, let's switch the dependency from senthilganeshs.purejson to tonivade.purejson.

Thank you for your contribution and help.

@fabienrenaud fabienrenaud merged commit 4e95229 into fabienrenaud:master May 30, 2024
1 check passed
@Philzen Philzen deleted the update-jackson-lib branch May 30, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants