Bytecode Extractor / Disassembly #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egers anywhere we deal with the mementry state field. Also using type==Resource::RT_SOUND instead of type==0 in sfxplayer.cpp.
…variable indexing.
|
Great job on 8934c32, it makes things much clearer: If you can send it as an individual pull request, I will merge it. With regards to the bytecode analyzer I will merge it when you have something fully functional. For now it looks like it is a work in progress. I woud suggest to use an array to establish a 1to1 mapping instead of the huge switch cases like here: |
use PC_OFFSET and REQUESTED_PC_OFFSET instead of integers for indexing threadsData
- disassemble only bytecode resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of a bytecode dumper/disassembler