-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to make active list filters more visible #178
Add option to make active list filters more visible #178
Conversation
Codecov ReportBase: 98.13% // Head: 98.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 98.13% 98.16% +0.02%
==========================================
Files 34 35 +1
Lines 376 381 +5
==========================================
+ Hits 369 374 +5
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@merwok thank your very much also for this PR, very cool and useful! Do you still need to work on this PR or I can merge it? |
The PR contains item A from the discussion, I will add item C too! I also wanted feedback about the styles from you and from my client who’s funding this work 🙂 |
f4e0e62
to
c50b2b5
Compare
admin_interface/templates/django-admin-autocomplete-filter/autocomplete-filter.html
Outdated
Show resolved
Hide resolved
My personal feedback on style:
I'm glad for you that your client is funding this work! |
I think now that item A and C are two different features and probably it's better to have the possibility to enable them separately, do you agree? |
48fd5fd
to
c50b2b5
Compare
I was already planning to have two different settings, and we can also have two PRs. |
Thanks for the feedback! I will try to apply it after a weekend, unless you want to do it quickly and add commits to this branch. |
No hurry, have a nice weekend! |
@merwok maybe we could start to merge this PR? |
I think the CSS tweaks need to be addressed! |
@merwok I agree, I wait for the CSS changes. |
Fixes #174