Allow changing background color #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the default values from help text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 97.38% 97.46% +0.08%
==========================================
Files 38 40 +2
Lines 420 434 +14
==========================================
+ Hits 409 423 +14
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
merwok
reviewed
Sep 24, 2024
| @@ -38,6 +38,10 @@ msgstr "Favicon" | |||
| msgid "Title" | |||
| msgstr "Titre" | |||
|
|
|||
| #: admin_interface/admin.py | |||
| msgid "Body" | |||
| msgstr "Body" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Changed ! Thanks for feedback !
merwok
reviewed
Sep 24, 2024
| @@ -174,10 +178,30 @@ msgstr "code" | |||
| msgid "display" | |||
| msgstr "affichage" | |||
|
|
|||
| #: admin_interface/models.py | |||
| msgid "Required fields, error messages" | |||
| msgstr "Défaut: #333 (champs requis, messages d'erreur)" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Changed ! Thanks for feedback !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
I added 4 customization options to Themes :
And extended French translation for the newly added fields.
I couldn't find places where loud color was used, but it felt awkward to add the option for the quiet color without the loud color.
Related issue
#291
Checklist before requesting a review
I'm reopening this because the change was reverted, but no idea why ? So far, I've used my own fork on different projects without any noticeable issue