Fix a bug for CallbackHandler.callback_list (huggingface#8052)

* Fix callback_list * Add test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix test Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
fabiocapsouza · Nov 15, 2020 · d8380db · d8380db
1 parent 278a2d4
commit d8380db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/transformers/trainer_callback.py b/src/transformers/trainer_callback.py
@@ -325,7 +325,7 @@ def remove_callback(self, callback):
 
     @property
     def callback_list(self):
-        return "\n".join(self.callbacks)
+        return "\n".join(cb.__class__.__name__ for cb in self.callbacks)
 
     def on_init_end(self, args: TrainingArguments, state: TrainerState, control: TrainerControl):
         return self.call_event("on_init_end", args, state, control)

diff --git a/tests/test_trainer_callback.py b/tests/test_trainer_callback.py
@@ -221,3 +221,10 @@ def test_event_flow(self):
         trainer.train()
         events = trainer.callback_handler.callbacks[-2].events
         self.assertEqual(events, self.get_expected_events(trainer))
+
+        # warning should be emitted for duplicated callbacks
+        with unittest.mock.patch("transformers.trainer_callback.logger.warn") as warn_mock:
+            trainer = self.get_trainer(
+                callbacks=[MyTestTrainerCallback, MyTestTrainerCallback],
+            )
+            assert str(MyTestTrainerCallback) in warn_mock.call_args[0][0]