Domain overrides settings #35 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocicerchia
added
bug
|
This pull request introduces 1 alert when merging 2bbb7e5 into 5ec0065 - view on LGTM.com new alerts:
|
fabiocicerchia
commented
Sep 2, 2021
fabiocicerchia
commented
Sep 2, 2021
|
This pull request introduces 1 alert when merging e1fa2bd into 5ec0065 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7b7e3ae into 5ec0065 - view on LGTM.com new alerts:
|
|
fabiocicerchia
commented
Sep 3, 2021
| @@ -135,7 +136,9 @@ func (c Object) handleMetadata(domainID string, targetURL url.URL, expiration ti | |||
| // StoreFullPage - Stores the whole page response in cache. | |||
| func (c Object) StoreFullPage(expiration time.Duration) (bool, error) { | |||
| if !c.IsStatusAllowed() || !c.IsMethodAllowed() || expiration < 1 { | |||
| log.Debugf( | |||
| log.WithFields(log.Fields{ | |||
server/server.go
Outdated
| // timeout middleware | ||
| // NOTE: THIS IS FOR EVERY DOMAIN, NO DOMAIN OVERRIDE. | ||
| // WHEN SHARING SAME PORT NO CUSTOM OVERRIDES ON CRITICAL SETTINGS. | ||
| timeout := config.Config.Server.Timeout | ||
| // TODO! CONVERT FOR DOMAIN CONFIG |
| ) | ||
|
|
||
| // LoggedResponseWriter - Decorator for http.ResponseWriter. | ||
| func (lwr LoggedResponseWriter) GetLogger() *log.Entry { |
|
|
||
| // GetLogger - Get logger instance with RequestID. | ||
| func (rc RequestCall) GetLogger() *log.Entry { | ||
| return log.WithFields(log.Fields{ |
| func initRequestParams(res http.ResponseWriter, req *http.Request) (RequestCall, error) { | ||
| var configFound bool | ||
|
|
||
| reqID := xid.New().String() |
|
This pull request introduces 1 alert when merging b63caa2 into 5ec0065 - view on LGTM.com new alerts:
|
fabiocicerchia
commented
Sep 4, 2021
server/handler/gzip.go
Outdated
| // HandleRequestWithETag - Add HTTP header ETag only on HTTP(S) requests. | ||
| func WrapResponseForGZip(res *response.LoggedResponseWriter, req *http.Request) { | ||
| if !strings.Contains(req.Header.Get(headers.AcceptEncoding), "gzip") { | ||
| return // TODO! COVER |
server/handler/http.go
Outdated
| proxy.ServeHTTP(rc.Response, rc.Request) | ||
| serveNotModified := rc.GetResponseWithETag(proxy) | ||
| if serveNotModified { | ||
| rc.Response.SendNotModifiedResponse() // TODO! COVER |
|
This pull request introduces 1 alert when merging 55b599a into 5ec0065 - view on LGTM.com new alerts:
|
fabiocicerchia
force-pushed
the
fix/issue-35
branch
from
55b599a to
6ea2010
Compare
|
This pull request introduces 1 alert when merging 5e54cb8 into 5ec0065 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain overrides settings #35