LB Algorithms #108
Merged
LB Algorithms #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocicerchia
force-pushed
the
feature/issue-15
branch
2 times, most recently
from
e6fadb1 to
8dc30c5
Compare
fabiocicerchia
force-pushed
the
feature/issue-15
branch
from
8dc30c5 to
b352191
Compare
fabiocicerchia
commented
Sep 10, 2021
| // HealthCheckInterval - Health Check Frequency | ||
| const HealthCheckInterval time.Duration = 30 * time.Second | ||
|
|
||
| // TODO: make it customizable |
|
|
||
| rc.GetLogger().Debugf("Async Store Response: %s", rc.Request.URL.String()) | ||
| go doStoreResponse(rcDTO, rc.DomainConfig.Cache) | ||
| rc.GetLogger().Debugf("Sync Store Response: %s", rc.Request.URL.String()) |
There was a problem hiding this comment.
is the connection with client closed? if so, it's ok
| @@ -29,7 +29,9 @@ import ( | |||
| "github.com/fabiocicerchia/go-proxy-cache/utils" | |||
| ) | |||
|
|
|||
| var r *dnscache.Resolver = &dnscache.Resolver{} | |||
| var r *dnscache.Resolver = &dnscache.Resolver{ | |||
| // TODO: Customize timeout | |||
|
This pull request introduces 1 alert when merging 3a74484 into 4ab33a3 - view on LGTM.com new alerts:
|
fabiocicerchia
commented
Sep 13, 2021
|
This pull request introduces 1 alert when merging d61a1ae into 4ab33a3 - view on LGTM.com new alerts:
|
fabiocicerchia
added a commit
that referenced
this pull request
Apr 1, 2022
* new: LB Algorithms #15 * refactoring * refactoring + added docs * minor changes + fixing data races * fixing pipeline * added tests for different lb algo * code review * Update .github/workflows/main.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15