Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Forwarded-Port should use local port #122

Closed
robholland opened this issue Jun 30, 2016 · 4 comments
Closed

X-Forwarded-Port should use local port #122

robholland opened this issue Jun 30, 2016 · 4 comments
Labels
Milestone

Comments

@robholland
Copy link

Heya,

The X-Forwarded-Port header should be set to the port on which fabio received the request, not the port that you are going to send the traffic to. The server that's receiving the traffic already knows what port it's on :)

@robholland
Copy link
Author

This breaks origin checks on applications using rack-protection as it expects the Origin header to include the port number that the backend server is listening on, which is unlikely to ever be correct unless everything happens to be using port 80 internally as well.

@magiconair
Copy link
Contributor

@robholland The patch should fix it. Can you test it?

@robholland
Copy link
Author

Yep, that fixed it for us, cheers!

@magiconair magiconair changed the title X-Forwarded-Port is set to the wrong value X-Forwarded-Port should use local port Jul 2, 2016
@magiconair magiconair added this to the 1.1.6 milestone Jul 2, 2016
@magiconair
Copy link
Contributor

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants