Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting routes by tag #201

Closed
killcity opened this issue Dec 1, 2016 · 6 comments
Closed

Support deleting routes by tag #201

killcity opened this issue Dec 1, 2016 · 6 comments
Milestone

Comments

@killcity
Copy link

killcity commented Dec 1, 2016

Is there a way to setup an override that will send 0% traffic to nodes that have a specific tag. That way we can still see the node is a member of the pool but temporarily not having any traffic sent to it because of it's tag status.

Examples:

Route set to 0% based on tag "maint_mode" (using -1 as an example of sending 0% traffic)
route weight appservice testsite.com/app weight -1 tags "maint_mode"

Route deleted based on tag "maint_mode"
route del appservice testsite.com/app tags "maint_mode"

Cheers

@magiconair
Copy link
Contributor

magiconair commented Dec 1, 2016 via email

@killcity
Copy link
Author

killcity commented Dec 1, 2016

Yah, precisely. Looks like you read my comment before I edited with examples. You're too quick. :)

@magiconair
Copy link
Contributor

I'll add that after I've fixed the weighing bug. (#186)

@magiconair magiconair changed the title Question: override to not send traffic to nodes with a specific tag Support deleting routes by tag Dec 1, 2016
@killcity
Copy link
Author

killcity commented Dec 3, 2016

Thanks again. Need to learn Go for 2017 so I can contribute :)

@magiconair magiconair added this to the 1.4 milestone Dec 6, 2016
magiconair added a commit that referenced this issue Dec 8, 2016
magiconair added a commit that referenced this issue Dec 8, 2016
Step 2: Add functionality

Support deleting routes by tags and service and tags.
@magiconair
Copy link
Contributor

Implementing this pushed me into refactoring the table parser tests a bit more. This patch adds support for

# delete routes of <svc> which have tags 'a' and 'b'
route del svc tags "a,b"

# delete routes which have tags 'a' and 'b'
route del tags "a,b"

magiconair added a commit that referenced this issue Dec 8, 2016
Add support for deleting routes by tags.
magiconair added a commit that referenced this issue Jan 17, 2017
Add support for deleting routes by tags.
@magiconair
Copy link
Contributor

Merged the change to master. Please test.

@magiconair magiconair modified the milestones: 1.4, 1.3.7 Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants