-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor listener config #28
Comments
Won't happen for 1.0.9 unfortunately. |
Maybe it would be a good idea to allow a list of certificates for each listener, so that multiple Domains can be served on the same port. As I saw, golang supports a slice of Certificates in tls.Config{} and should be able to create a mapping of the CommonName and SubjectAlternateName provided in the certificate (see also tls.Config.BuildNameToCertificate()) Maybe the configuration then should be something like: |
I've started working on that to support #27 and #70 and #79 - which will support multiple dynamic certificates per listener - and will probably settle for
This allows me to specify an arbitrary number of options without going crazy on parameter parsing. It is a similar approach as with the |
The listener configuration in
proxy.addr
seemed like a good idea but wasn't. To provide parameters for read and write timeout and reuse the same configuration also for the UI (see issue #25) I'm planning to change the configuration of the listeners as follows:The same options will be available for the UI/API listener and the same code will start all listeners.
proxy.addr
andui.addr
will be deprecated with a startup warning and removed in a later release.The text was updated successfully, but these errors were encountered: