Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host=www.mydomain.com not working #375

Closed
discobean opened this issue Oct 20, 2017 · 4 comments
Closed

host=www.mydomain.com not working #375

discobean opened this issue Oct 20, 2017 · 4 comments
Milestone
1.5.3

Comments

@discobean
Copy link

discobean commented Oct 20, 2017 •
edited by magiconair
Loading

Hi,

If using host=dst it works as expected, but it looks like when specifying an override and using opts host=www.mydomain.com will not pass the host header as www.mydomain.com

Example override:

route add marz-test marz-test.domain.com/ http://52.15.183.149/ opts "host=916c80f7.ngrok.io"

The documentation here: https://github.com/fabiolb/fabio/wiki/Routing specifies that host=domainname can be used
@magiconair
Copy link
Contributor

I'll have a look.

magiconair added a commit that referenced this issue Oct 22, 2017
@magiconair
Issue #375: set host header when host option is set
ee7c8e4 
This patch sets the Host header when the `host` option is set but not
`dst`.

Fixes #375
@magiconair magiconair mentioned this issue Oct 22, 2017
Merged
@magiconair
Copy link
Contributor

magiconair commented Oct 22, 2017 •
edited
Loading

@discobean I had the right instinct on #301. We would need to set host to something else as well. Looks like I was getting ahead of myself in the docs. Looks like this was an obvious thing. Could you test this?

@magiconair magiconair added this to the 1.6 milestone Oct 22, 2017
@magiconair
Copy link
Contributor

The only thing where I'm not sure are the requests where users want to set arbitrary headers on the request. However, this solves a problem now.

@discobean
Copy link
Author

discobean commented Oct 22, 2017 •
edited
Loading

Yep, this patch is confirmed working now :)

We also use the dst feature too

magiconair added a commit that referenced this issue Oct 23, 2017
@magiconair
Issue #375: set host header when host option is set
b199874 
This patch sets the Host header when the `host` option is set but not
`dst`.

Fixes #375
@magiconair magiconair mentioned this issue Nov 3, 2017
Closed
@magiconair magiconair modified the milestones: 1.6, 1.5.3 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.3
Development

No branches or pull requests
2 participants
@magiconair @discobean