Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route updates are delayed with large number of services #558

Closed
galen0624 opened this issue Oct 11, 2018 · 2 comments
Closed

Route updates are delayed with large number of services #558

galen0624 opened this issue Oct 11, 2018 · 2 comments
Milestone
1.5.11

Comments

@galen0624
Copy link
Collaborator

galen0624 commented Oct 11, 2018 •
edited
Loading

We have a large number of services > 2500. The watchBackend func is taking over 15-20 seconds due to the sequential service queries. I am proposing an update to the below code to be a go func with worker pools.

https://github.com/fabiolb/fabio/blob/master/registry/consul/service.go#L57

I will PR this hopefully early next week.
galen0624 added a commit to galen0624/fabio that referenced this issue Oct 23, 2018
@galen0624
issue fabiolb#558 added go routine for consul service calls
b52ba53
@galen0624 galen0624 mentioned this issue Oct 23, 2018
Closed
@magiconair magiconair mentioned this issue Oct 27, 2018
Merged
@galen0624
Copy link
Collaborator Author

Closing with #564

@magiconair magiconair reopened this Oct 29, 2018
@magiconair
Copy link
Contributor

I'll keep this open as the issue which is the motivation for the PR.

@magiconair magiconair added this to the 1.5.11 milestone Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.11
Development

No branches or pull requests
2 participants
@magiconair @galen0624