Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matchingHostNoGlob sometimes returns incorrect matched host #786

Closed
nathanejohnson opened this issue Sep 9, 2020 · 0 comments
Closed

matchingHostNoGlob sometimes returns incorrect matched host #786

nathanejohnson opened this issue Sep 9, 2020 · 0 comments

Comments

@nathanejohnson
Copy link
Member

related to #506 , it seems that matchingHostNoGlob doesn't do this reverse sort. It just picks the first one it finds.
nathanejohnson added a commit that referenced this issue Sep 9, 2020
@nathanejohnson
Fixing issue #786 - matchingHostNoGlob sometimes returns incorrect host
74ed180
nathanejohnson added a commit that referenced this issue Sep 9, 2020
@nathanejohnson
Fixing issue #786 - matchingHostNoGlob sometimes returns incorrect host
f7819fe 
Moves logic for reversing hosts / ports to get most specific match into
separate method

Calls this same method from both matchingHost and matchingHostNoGlob
nathanejohnson added a commit that referenced this issue Sep 9, 2020
@nathanejohnson
Fixing issue #786 - matchingHostNoGlob sometimes returns incorrect host
a6c2549 
Moves logic for reversing hosts / ports to get most specific match into
separate method

Calls this same method from both matchingHost and matchingHostNoGlob
nathanejohnson added a commit that referenced this issue Sep 9, 2020
@nathanejohnson
Merge pull request #787 from fabiolb/issue-768-matchingHostNoGlob
371346a 
Fixing issue #786 - matchingHostNoGlob sometimes returns incorrect host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanejohnson