Add a golang-linter to CI #972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tristanmorgan may you merge into master this PR and PR #971 and I will add other linters step-by-step? Lot of thanks! |
|
I've Merged #971, I'm trying to get some feedback from the other maintainers about what linting we should apply. As food for thought, on my personal fork (and other work) I often use the following tools:
|
|
@tristanmorgan Hi, I believe the golangci-lint linter contains almost all those you listed (and more: https://golangci-lint.run/usage/linters/) except a vulnerability check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a golangci-lint (https://github.com/golangci/golangci-lint) into CI.
Currently, as a first stage, enable only one linter (nonascii symbols) and fix error into code.
In a next stages, I will enable a part of linters and fix errors.