This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
limit search request time to 30 seconds #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies like "timed-out" and their sub-dependencies are accessing `req._headers` directly instead of using e.g. `res.getHeaders()` long term, upstream packages should be updated or replaced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
underlying libs (torrent-search-api) aren't setting a timeout for search requests, as described in #22.
this pr tries to address this by adding a promise race with a cancel timeout of 30 seconds.
if you'd prefer a config setting for this value, i can add that, but would prefer you decide what to call it and where it lives in the config. thanks