Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements #2

Closed
yzhang-gh opened this issue Oct 23, 2018 · 4 comments
Closed

UI enhancements #2

yzhang-gh opened this issue Oct 23, 2018 · 4 comments

Comments

@yzhang-gh
Copy link
Contributor

It might be better to

  1. make use of the theme foreground colour for status bar item
    image
  2. mimic vscode notification center (adding notification number)
    image
@fabiospampinato
Copy link
Owner

make use of the theme foreground colour for status bar item

This is a bit tricky. First of all there are already settings for changing all the colors.

Now, that statusbar item has 3 states: no notifications, some notifications and some notifications and participating. I assume in your screenshot it's in the no notifications state.

I could change this color to be the default one, then the some notifications color might be white and participating might still be yellow. This would work better in your theme, but not in other themes where by default the color is white. In that situation it would be impossible to distinguish, without manually setting the colors, between no notifications and some notifications.

Until they implement this I can't provide good defaults for everyone.

mimic vscode notification center (adding notification number)

The notification center is always displayed, so they need to show the counter to notify that there are some notifications. This extension uses color for that instead. Also you can hide the icon if there are no notifications.

You can already hover over the icon and get the counters.

Adding a setting or something for writing those counters to the statusbar would be nice though, thanks for the suggestion 👍

@yzhang-gh
Copy link
Contributor Author

It occurred to me that there might be two schemes.

The first one is the current solution, using different colours to indicate 3 different states.
The other one is what VSC does, no different colours but it shows the number of messages.

In the second setting, we can always reference statusBar.foreground theme key.

@yzhang-gh
Copy link
Contributor Author

BTW, why bother distinguishing some notifications and some notifications and participating? Both ends up with opening in the browser (at least for me😂)

@fabiospampinato
Copy link
Owner

Originally I thought that notifications about things I'm actually participating in would be more important to me, but at the end of the day I'm just keep viewing both of them. In hindsight it probably just over-complicated things.

I'm currently working on other stuff, and these changes aren't really necessary for me, but if you want to make the changes yourself I'll be happy to consider a PR that:

  • Removes the extra some notifications and participating state
  • Uses the default color when there are no notifications and a custom, settable, color when there are some
  • Adds an option for displaying the number of notifications alongside the icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants