New copy-and-update warnings with Fable 4.4

[forki]

It looks like Fable 4.4 is using F# 8 features and also emits F# 8 warnings:

We see LOTS of new warnings. Things like:

warning FSHARP: This copy-and-update record expression changes all fields of record type 'MyRecordType'. Consider using the record construction syntax instead. (code 3560)

@MangelMaxime @ncave Is this expected?

references dotnet/fsharp#16182

[ncave]

@forki You are correct, sounds like a lot of people have concerns about warning 3560 and so it will be turned off by default in F# 8.0 final (post-RC2). It hasn't been merged in F# main yet, but I can cherry-pick it and have a new build shortly.

[nojaf]

Add <NoWarn>$(NoWarn);FS3560</NoWarn> for now.

[forki]

@nojaf it's not just that particular one. there are more. But yes that is a valid workaround

[nojaf]

@ncave is --langversion being passed to FCS as an argument?

[ncave]

I updated FCS in #3568 to turn off 3560 by default, it will be in the next release.
++ @MangelMaxime

[ncave]

@nojaf

is --langversion being passed to FCS as an argument?

I believe so, not sure as an Fable CLI argument, but most of what's in your .fsproj will be passed to FCS.
Looks like the project cracker will pick it up, either as an Fable CLI argument or if it's in your .fsproj.

[MangelMaxime]

Thank you @ncave.

I just released a new version, @forki can you please check if this fixed all the warnings you had?

[forki]

Friends, thank you very much for this super duper fast fix. I'll test it tomorrow morning in the office. Hugs. Maxime Mangel ***@***.***> schrieb am Mi., 25. Okt. 2023, 19:48:

…

Thank you @ncave <https://github.com/ncave>. I just released a new version, @forki <https://github.com/forki> can you please check if this fixed all the warnings you had? — Reply to this email directly, view it on GitHub <#3567 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOANAPIVNG5DQ2GM7O4QLYBFGFNAVCNFSM6AAAAAA6PKRLICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZG43DMNJZHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[forki]

yes it works. Thank's a lot.