Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing .gitignore file in the generated fable_modules/ folder #3603

Closed
MangelMaxime opened this issue Nov 20, 2023 · 1 comment · Fixed by #3711
Closed

Missing .gitignore file in the generated fable_modules/ folder #3603

MangelMaxime opened this issue Nov 20, 2023 · 1 comment · Fixed by #3711
Labels
bug up-for-grabs

Comments

@MangelMaxime
Copy link
Member

Description

fable_modules folder should have a .gitignore file generated with **/* content.

However, it seems like this is not the case anymore.

Repro code

  1. dotnet new console -lang f# --name reproBugFableMobules
  2. cd reproBugFableMobules
  3. dotnet new tool-manifest
  4. dotnet tool install fable
  5. dotnet fable
  6. ls -a fable_modules

See that there is no .gitignore file.

Expected and actual results

Should have a .gitiginore file generated.

Related information

  • Fable version: 4.5.0
  • Operating system: OSX
@MangelMaxime
Copy link
Member Author

It seems like this bugs returns in Fable 4.9.0

MangelMaxime added a commit that referenced this issue Jan 23, 2024
@MangelMaxime
Port back fixes for missing .gitignore
5fbfc92 
Fix #3603
@MangelMaxime MangelMaxime mentioned this issue Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port back fixes for missing .gitignore fable-compiler/Fable
1 participant
@MangelMaxime