Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.String.EndsWith is not supported by Fable #3934

Closed
laurentpayot opened this issue Oct 21, 2024 · 5 comments
Closed

System.String.EndsWith is not supported by Fable #3934

laurentpayot opened this issue Oct 21, 2024 · 5 comments

Comments

@laurentpayot
Copy link

Description

I have a project where I use FSharpPlus.
When pretest-compiling its Fable.Mocha test project with dotnet fable ./tests/tests.fsproj -o output/tests, I get the following:

./output/tests/fable_modules/FSharpPlus.1.6.1/Extensions/String.fs(74,8): (74,72) error FABLE: System.String.EndsWith is not supported by Fable
Compilation failed

Is FSharpPlus endsWith code the culprit? Or could it be something special in the way endsWith is implemented in Fable?

Related information

  • Fable version: 4.22.0
  • Operating system: Ubuntu 24.04.1 LTS
@laurentpayot
Copy link
Author

Related to #2601?

@ncave
Copy link
Collaborator

ncave commented Oct 22, 2024

Fixed by #3935

@ncave ncave closed this as completed Oct 22, 2024
@laurentpayot
Copy link
Author

Awesome. Thanks @ncave!

@ncave
Copy link
Collaborator

ncave commented Oct 22, 2024

@laurentpayot No worries, mate, it's easy when the code is mostly already there, just needs to be enabled.

Once released, you may want to submit a PR for FSharpPlus repo to have the conditional around startsWith removed too.

@laurentpayot
Copy link
Author

@ncave Just waiting for the release to do the PR then 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants