-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fable 2.1: back to npm, back home #1639
Conversation
Just to confirm we are moving only Also, if |
|
||
type AgentMsg = | ||
| Received of hanlder: IMessageHandler | ||
| Respond of response: obj * hanlder: IMessageHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos here.
| Respond(value, msgHandler) -> | ||
msgHandler.Respond(fun writer -> | ||
// Don't use `use` (pun unintended), it will close the underlying writer | ||
let jsonWriter = new JsonTextWriter(writer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this?
use writer = new JsonTextWriter (writer, CloseOutput=false)
Looks like the JsonTextWriter
returns a buffer back to a pool on Close
, which is called by Dispose
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Let's do that, thank you!
aabdfd8
to
6c09c94
Compare
@MangelMaxime Everything was totally clear in the first comment, how you didn't understand? 😸 Jokes aside, yes, this is only about moving dotnet-fable (Fable CLI, Fable dotnet binaries or however you want to call it) to npm (actually the official name of the package is In fact users won't even need to care about About |
Can we start Fable with a debugger attached with this setup? |
@inosik I already added a |
@alfonsogarciacaro Seems good too me and looks like the right decision for managing the tool version and making integration with webpack even better :) Just wanted to make sure :) |
03344e3
to
fed5d19
Compare
@alfonsogarciacaro Yeah, I've already seen this setting, but honestly I didn't expect it to be the path to the project file instead of pointing to an assembly. Adding an |
7555e24
to
4cb811c
Compare
fed5d19
to
1dcbda5
Compare
d54ef8b
to
1a9aece
Compare
017c447
to
8a9632e
Compare
9f8f37f
to
90b9950
Compare
90b9950
to
e9769b0
Compare
Fable 2.1 has been released 😸 |
In the beginning Fable was distributed through npm, and all was good.
Then Enrico, the prophet, came and showed us the promise land of netcore. We followed him but when we reached the gates of paradise we heard a voice: "If you want to enter, you must forget npm and embrace Nuget, you must become a dotnet cli tool".
There was fear, everybody could remember scary stories of Nuget from the old days. Nobody dared to move, but then one man stepped forward, his name was forki. "Fear not", he said, "for I will make Paket handle dotnet cli tools".
There was a big party that night, Paket kept the cli tools and the other Nuget packages under a tight lock so they would make no harm. The gates of paradise could be crossed now.
Soon however, some people raised their voice: "why do I have to type three commands? What is this, dotnet, fable, webpack? My head hurts". But the voices were silenced: "Don't try to understand such arcana", they said, "Maxime, the French magician, will unveil the mysteries for us and bring the Webpack configs and Fake scripts".
So people were happy and felt SAFE. But then the voice of the big M came down from the sky again: "You, why are you using dotnet cli tools?". "Because you told us to do so", the fablers replied. "How you dare, you fools! Dotnet cli tools were a mischief from the devil and I shall provide support no more".
The fablers were confused, they were trying to build bridges between two worlds, but the currents were constantly changing. At the moment of biggest despair, there was an open hand from the other side: "Come back, my prodigal son. Do you want to be a cli tool? No ProbleM! You can be whatever you want to be if you come with me. You can put any files you want in your packages. Dotnet assemblies? It's ok, I won't judge you! The only tribute you need to pay is just a little json."
And fablers saw the light: if we need to call webpack anyways, why not just type "webpack"? Why not put the dotnet assembly in an npm package and let fable-loader spawn it a subprocess? Why not communicate with it just through stdin? Then users won't have to worry, just install the fable loader and be done.
Suddenly, the sky cleared and a ray of light fell onto the fablers. The netcore trees hadn't let them see the forest of the user experience so far. But now the answer was clear, they wouldn't wait for big M promises any longer. They would go back to npm, back home.