Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of dereferenced byref #3712

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

@MangelMaxime
Copy link
Member

Hello @chkn,

I tested the added test that you made against the current version of REPL and it report 3 as you expected.

I also tried the test your added against the current version of the main branch of Fable and it passed too (without your Replacement changes).

This lead me to 2 directions:

  1. The added test doesn't test the issue you are trying to fix
  2. The issue you try to fix is already fixed in latest version of Fable?

Note: I am not sure what is the expected output of the REPL code your linked? Could you please tell me where is the wrong code and what it should have generated?

@chkn
Copy link
Contributor Author

chkn commented Jan 24, 2024

Hey @MangelMaxime,

Thanks for taking a look at my PR so quickly!

Apologies for not being clearer, the issue is only in the types, so you need to switch the REPL to TypeScript mode to see it:
Screenshot 2024-01-24 at 12 35 28 PM

The test case I added also failed to compile without my change when I ran the TypeScript tests like so:

./build.sh test typescript

@ncave ncave assigned ncave and unassigned ncave Jan 24, 2024
@ncave ncave requested review from ncave and removed request for ncave January 24, 2024 17:46
@ncave ncave merged commit 3a51f87 into fable-compiler:main Jan 24, 2024
18 checks passed
@chkn chkn deleted the fix-deref-byref-type branch January 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants