WIP: Add support for StringBuilder.Chars
for Rust
#3760
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ncave ,
While trying to add support for
StringBuilder.Charts
to Rust I run into an issue wherefable-library-rust
cannot be compiled.While looking at the generated source code I discovered that
member
haveself: &Lrc<Self>
generated butgetter/setter
have&self
.Manually changing
to
seems to make the error go away at least in the IDE.
I found that the line responsible for generating
&Lrc<Self>
isFable/src/Fable.Transforms/Rust/Fable2Rust.fs
Lines 3352 to 3374 in f96d458
But it doesn't work in the current situation because the
ident.Type
andreturnType
are different. I am not sure what is the path of action to take from here.