[bugfix] Bump bundled ruby to 2.7 branch to include fix for m1 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know when the next release for Ruby 2.7 is planned. In case it's helpful for review here are all the changes between v2.7.6 and 2_7: ruby/ruby@v2_7_6...ruby_2_7 |
reese
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ruby submodule was pointing to an older version of ruby 2.7 which did not contain fix for M1 apple silicon.
The latest fixes have not yet been released as a patch version for ruby 2.7.X. I'm now using the default ruby 2.7 branch which works with rubyfmt without any issue.
With this patch, I can successfully build rubyfmt on M1 apple silicon (also tested in Mac OSX Ventura)
For example: ruby/ruby#6297 is where ruby has the patch for building in M1 but is not in 2.7.6 ruby tag.
cc: @penelopezone @reese